Refactoring constants for skip validations #6190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/M
pokearu
changed the title
Codecov Report
@@ Coverage Diff @@
## main #6190 +/- ##
=======================================
Coverage 75.01% 75.01%
=======================================
Files 448 448
Lines 36972 36971 -1
=======================================
Hits 27734 27734
+ Misses 7676 7675 -1
Partials 1562 1562
|
mitalipaygude
approved these changes
Jul 17, 2023
|
/test eks-anywhere-presubmit |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pokearu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5865:
Description of changes:
Refactoring constants and adding
vsphere-user-privilegefor upgrade.Testing:
Tested creating a cluster by skipping the check
Documentation added/planned :
Plan to document the new flag and user experience.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.